Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPP] Delete simple payments migration flow #13814

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

[IPP] Delete simple payments migration flow #13814

wants to merge 4 commits into from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Mar 20, 2025 •
edited
Loading

Closes: #13813

Description

The PR deletes all the code related to Migrating from the Simple Payments flow that starts from payments hub

Steps to reproduce

Testing information

  • Try to find any code that was not deleted, unused and related to the Simple Payments migration flow
  • Validate that visually all good in the payments hub

The tests that have been performed

Above

Images/gif

image
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Mar 20, 2025 that may be closed by this pull request
[IPP] Delete simple payments migration flow #13813
Open
@kidinov kidinov marked this pull request as draft March 20, 2025 10:10
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 20, 2025 •
edited
Loading

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 20, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit4713bae
Direct Downloadwoocommerce-wear-prototype-build-pr13814-4713bae.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 20, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit4713bae
Direct Downloadwoocommerce-prototype-build-pr13814-4713bae.apk

@kidinov kidinov added this to the 22.1 milestone Mar 20, 2025
@kidinov kidinov added feature: mobile payments Related to mobile payments / card present payments / Woo Payments. status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Mar 20, 2025
@kidinov
Copy link
Contributor Author

kidinov commented Mar 20, 2025 •
edited
Loading

Do not merge, as there is no final decision yet

pdfdoF-6KN-p2

UPD: we go forward with this removal!

@kidinov kidinov requested a review from AnirudhBhat March 20, 2025 14:23
@kidinov kidinov marked this pull request as ready for review March 20, 2025 14:24
@kidinov kidinov removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Mar 27, 2025
@kidinov kidinov added the category: tracks Related to analytics, including Tracks Events. label Mar 27, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.14%. Comparing base (ae35023) to head (4713bae).

Additional details and impacted files 
@@             Coverage Diff              @@
##              trunk   #13814      +/-   ##
============================================
- Coverage     38.15%   38.14%   -0.01%     
+ Complexity     9296     9293       -3     
============================================
  Files          2082     2082              
  Lines        114950   114922      -28     
  Branches      14648    14645       -3     
============================================
- Hits          43859    43840      -19     
+ Misses        67102    67094       -8     
+ Partials       3989     3988       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnirudhBhat AnirudhBhat Awaiting requested review from AnirudhBhat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: tracks Related to analytics, including Tracks Events. feature: mobile payments Related to mobile payments / card present payments / Woo Payments.
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.

[IPP] Delete simple payments migration flow
4 participants
@kidinov @dangermattic @wpmobilebot @codecov-commenter